Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New importer #33

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

New importer #33

wants to merge 8 commits into from

Conversation

RealOrangeOne
Copy link
Contributor

@RealOrangeOne RealOrangeOne commented Jun 29, 2021 •
edited
Loading

Add a new importer, developed internally at Torchbox for a client project.

The benefits here are:

  • Less code, which is easier to follow
  • Performance improvements
  • Expose possible errors, so they can be fed back to the end user if needed

The bulk of the work is in wagtail_airtable/importer.py

I also took the opportunity to replace the explicit usage of MockAirtable with unittest.mock.patch.

@RealOrangeOne RealOrangeOne marked this pull request as ready for review June 30, 2021 14:25
@KalobTaulien
Copy link
Collaborator

This looks like a huge improvement! I'll try and find some time soon to review and user test this, and then make a package version bump.

Thank you for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KalobTaulien KalobTaulien Awaiting requested review from KalobTaulien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RealOrangeOne @KalobTaulien